Rewrite the TOML parser for v1.1.0 conformance - #32953
Merged
Merged
Claude / Claude Code Review
completed
Jun 28, 2026 in 14m 3s
Code review found 2 potential issues
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/toml/generate_toml_test_suite.ts:40-43 |
Test-suite generator does not actually pin the toml-test commit |
| 🟡 Nit | packages/bun-types/bun.d.ts:798 |
TOML.parse .d.ts signature omits Blob |
Annotations
Check warning on line 43 in test/js/bun/toml/generate_toml_test_suite.ts
claude / Claude Code Review
Test-suite generator does not actually pin the toml-test commit
The no-path branch still does `git clone --depth 1` of HEAD and only *records* `git rev-parse HEAD` into the generated header — there's no `git checkout <sha>`, so the PR description's "pins the upstream commit" isn't quite accurate and CodeRabbit's pinning half of comment #3487176825 wasn't actually addressed (only the byte-input half was, in dbee64c). Because the recorded hash is part of the byte-compared output, `--check` without a path will report "stale" the moment upstream toml-test advanc
Check warning on line 798 in packages/bun-types/bun.d.ts
claude / Claude Code Review
TOML.parse .d.ts signature omits Blob
Nit: the new type union omits `Blob`, even though the PR description lists Blob as accepted, the runtime path (`with_text_format_source` with `accept_blob_or_buffer=true`) handles it, and `toml.test.ts:53` tests it with an `as any` cast to work around this gap. Since this PR is already widening the input union beyond the siblings' `string`-only signatures, adding `| Blob` would make it match the documented/tested behavior and let the `as any` go.
Loading