bun:sqlite: fix lone-surrogate encoding, out-of-range BigInt binding, and stale column names - #32841
Open
robobun wants to merge 6 commits into
Open
bun:sqlite: fix lone-surrogate encoding, out-of-range BigInt binding, and stale column names#32841robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Jul 31, 2026 in 14m 55s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/sqlite/lazy_sqlite3.h:27 |
Dead lazy_sqlite3_bind_text entries after switch to sqlite3_bind_text64 |
Annotations
Check warning on line 27 in src/jsc/bindings/sqlite/lazy_sqlite3.h
claude / Claude Code Review
Dead lazy_sqlite3_bind_text entries after switch to sqlite3_bind_text64
Nit: commit 31e6a6a switched both string-binding branches in `rebindValue` to `sqlite3_bind_text64`, so `sqlite3_bind_text` (the 32-bit-length variant) now has zero callers in Bun's own code — the four `lazy_sqlite3_bind_text` entries here (typedef line 27, inline var line 137, `#define` line 236, `dlsym` line 375) are dead. This PR already removed the four `sqlite3_bind_text16` entries for the identical reason; these four should go too for consistency with REVIEW.md's "delete dead code in the s
Loading