http: don't retry a fetch with a ReadableStream body on keep-alive disconnect - #32798
Merged
Merged
Claude / Claude Code Review
completed
Jun 27, 2026 in 21m 10s
Code review found 1 potential issue
Found 4 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/http/lib.rs:2889-2892 |
Comment exceeds 3-line limit (CLAUDE.md rule #13) |
Annotations
Check warning on line 2892 in src/http/lib.rs
claude / Claude Code Review
Comment exceeds 3-line limit (CLAUDE.md rule #13)
Nit: this comment is 4 lines, but CLAUDE.md rule #13 caps code comments at 3 — the same rule was just applied to the test header in d36fad9, and the other new comment at lines 1902-1904 is 3 lines. Could fold the last sentence into line 3 (or drop it, since `on_writable`'s re-flush is implied by "the data stays buffered").
Loading