bun:ffi: don't re-throw JSC's TerminationException from a JSCallback - #32792
Merged
Claude / Claude Code Review
completed
Jun 27, 2026 in 16m 36s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/JSFFIFunction.cpp:216-222 |
PR description stale: scriptExecutionStatus guard removed in 9c5224a but Fix section still describes it |
Annotations
Check warning on line 222 in src/jsc/bindings/JSFFIFunction.cpp
claude / Claude Code Review
PR description stale: scriptExecutionStatus guard removed in 9c5224a7 but Fix section still describes it
🟡 nit: the **Fix** section's third bullet ("The threadsafe task also now skips the call when the global's script execution has stopped … matching `MessagePort::dispatchOneMessage`") is now stale — commit 9c5224a7 dropped that guard in response to the earlier finding that it was inert, and the current `FFI_Callback_threadsafe_call` lambda goes straight from building arguments to `invokeFFICallback()` with no `scriptExecutionStatus` check. Drop or amend that bullet so the description matches the m
Loading