bun:ffi: don't re-throw JSC's TerminationException from a JSCallback - #32792
Merged
Claude / Claude Code Review
completed
Jun 26, 2026 in 16m 21s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/ffi/ffi.test.js:768-771 |
4-line comment in worker.js fixture exceeds CLAUDE.md 3-line cap |
Annotations
Check warning on line 771 in test/js/bun/ffi/ffi.test.js
claude / Claude Code Review
4-line comment in worker.js fixture exceeds CLAUDE.md 3-line cap
nit: this 4-line comment block above `const fire = new CFunction(...)` in the `worker.js` fixture string runs into root `CLAUDE.md` rule 13 ("Keep code comments to 3 lines max") — the same rule already applied to the C++ `invokeFFICallback` comment (1c818ac) and the test-header comment above this `it(...)`. Consider trimming to ≤3 lines keeping just the non-obvious bit (a threadsafe `JSCallback` enqueues a task rather than calling synchronously, so it runs at the top of the worker's event loop o
Loading