bun:ffi: don't re-throw JSC's TerminationException from a JSCallback - #32792
Merged
Claude / Claude Code Review
completed
Jun 26, 2026 in 16m 8s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/ffi/ffi.test.js:695-698 |
4-line bug-history comment above the worker.terminate() test exceeds CLAUDE.md comment rules |
Annotations
Check warning on line 698 in test/js/bun/ffi/ffi.test.js
claude / Claude Code Review
4-line bug-history comment above the worker.terminate() test exceeds CLAUDE.md comment rules
nit: this 4-line comment block is bug-history narrative ("made FFI_Callback_* clear and re-throw…"), running into the same root `CLAUDE.md` rules already applied to the C++ comment in 1c818ac — rule 13 ("Keep code comments to 3 lines max") and the line-239 guideline ("no bug history — that belongs in the PR description. Regression tests get exactly one comment: the issue URL"). Consider trimming to ≤3 lines (just the assertion message a future reader needs to recognize the regression) or replaci
Loading