http(h3): reject DATA before final response HEADERS in the HTTP/3 client - #32678
Open
robobun wants to merge 6 commits into
Open
http(h3): reject DATA before final response HEADERS in the HTTP/3 client#32678robobun wants to merge 6 commits into
robobun wants to merge 6 commits into
Claude / Claude Code Review
completed
Jul 11, 2026 in 27m 30s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/uws_sys/libuwsockets_h3.cpp:151-156 |
6-line comment exceeds the repo's 3-line max |
Annotations
Check warning on line 156 in src/uws_sys/libuwsockets_h3.cpp
claude / Claude Code Review
6-line comment exceeds the repo's 3-line max
This 6-line comment exceeds the repo's 3-line max (CLAUDE.md rule 13). Two sibling violations in this PR — in `packages/bun-usockets/src/quic.c` and `patches/lsquic/stream-error-code.patch` — were already shortened to three lines in 927cbe2 and f23d4ad after CodeRabbit flagged them; this one was added in the same round but slipped through. Consider compressing to something like:
```c
/* Test-only: DATA with no final-response HEADERS (RFC 9114 §4.1). Queued via
* backpressure so it flushes afte
Loading