perf_hooks: implement performance.eventLoopUtilization() - #32618
Open
robobun wants to merge 9 commits into
Open
Claude / Claude Code Review
completed
Jul 16, 2026 in 13m 39s
Code review found 4 potential issues
Found 1 candidates, confirmed 4. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 4 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/BunTTYState.h:1-23 |
Unrelated orphan file BunTTYState.h accidentally added to PR |
Annotations
Check warning on line 23 in src/jsc/bindings/BunTTYState.h
claude / Claude Code Review
Unrelated orphan file BunTTYState.h accidentally added to PR
This new header is unrelated to `eventLoopUtilization()` and appears to be a rebase artifact: nothing in the tree `#include`s it, it declares a 3-arg `Bun__ttySetMode(int fd, int mode, void* state)` that conflicts with the real 2-arg definition (wtf-bindings.cpp:109) and every caller (ProcessBindingTTYWrap.cpp:190/225/262, tty.rs:53), it declares `Bun__ttyStateSize()` which has no definition anywhere, and the PR description's own 19-file diffstat/evidence table omits it. Please drop it from this
Loading