Fire the close event on MessagePort - #32565
Closed
robobun wants to merge 9 commits into
Closed
Claude / Claude Code Review
completed
Jun 21, 2026 in 41m 21s
Code review found 2 potential issues
Found 4 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/webcore/MessagePort.cpp:156-157 |
Stale comment in startForClose(): MessagePortPipe::close() does not schedule drains |
Annotations
Check warning on line 157 in src/jsc/bindings/webcore/MessagePort.cpp
claude / Claude Code Review
Stale comment in startForClose(): MessagePortPipe::close() does not schedule drains
nit (doc-only): this comment says "so MessagePortPipe::close() on the peer can schedule a drain", but `MessagePortPipe::close()` doesn't schedule anything — it only stores the `Closed` bit and drops the inbox. The peer-wake is done by `wakePeerForClose()`, called separately from `MessagePort::close()`. The header comment for `startForClose()` in `MessagePort.h` already has the correct phrasing ("so the peer can wake this port to dispatch 'close'"); this should match. Same class of doc-rot fixed
Loading