jsc: drain rejected-promise list in O(n) instead of O(n^2) - #32554
Merged
Claude / Claude Code Review
completed
Jun 22, 2026 in 20m 7s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/process/process.test.js:810-813 |
Test comment still references deleted takeFirst() |
Annotations
Check warning on line 813 in test/js/node/process/process.test.js
claude / Claude Code Review
Test comment still references deleted takeFirst()
🟡 nit: same as the (resolved) cleanup at the C++ sites — "(instead of takeFirst() per element)" references a method this PR deletes, so a future reader has no referent. Drop the first sentence; "This test pins the observable behaviour: …" stands on its own.
Loading