Skip to content

epoll_pwait2: issue raw syscall, add Android gate and disable flag - #32490

Merged
Jarred-Sumner merged 10 commits into
mainfrom
farm/e256f127/epoll-pwait2-raw-syscall
Jun 21, 2026
Merged

epoll_pwait2: issue raw syscall, add Android gate and disable flag#32490
Jarred-Sumner merged 10 commits into
mainfrom
farm/e256f127/epoll-pwait2-raw-syscall

epoll_kqueue: latch off epoll_pwait2 on EFAULT as well

e7af444
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jun 21, 2026 in 19m 59s

Code review found 1 potential issue

Found 4 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/bun_core/env_var.rs:195-201 Stale comment: EFAULT missing from fallback errno list

Annotations

Check warning on line 201 in src/bun_core/env_var.rs

See this annotation in the file changed.

@claude claude / Claude Code Review

Stale comment: EFAULT missing from fallback errno list 

nit: this comment lists the fallback errnos as `ENOSYS/EPERM/EOPNOTSUPP/EACCES`, but commit e7af4446 in this PR added `EFAULT` to the latch in `epoll_kqueue.c:145`. Worth adding `EFAULT` here so the enumeration matches the code it's describing.
View more details on Claude