Skip to content

epoll_pwait2: issue raw syscall, add Android gate and disable flag - #32490

Merged
Jarred-Sumner merged 10 commits into
mainfrom
farm/e256f127/epoll-pwait2-raw-syscall
Jun 21, 2026
Merged

epoll_pwait2: issue raw syscall, add Android gate and disable flag#32490
Jarred-Sumner merged 10 commits into
mainfrom
farm/e256f127/epoll-pwait2-raw-syscall

Detect Android via cfg(target_os) instead of uname release string

fd6eb0a
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jun 18, 2026 in 25m 15s

Code review found 1 potential issue

Found 4 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/regression/issue/32489.test.ts:198-202 stderr captured but not surfaced in flagged-run failure assertions

Annotations

Check warning on line 202 in test/regression/issue/32489.test.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

stderr captured but not surfaced in flagged-run failure assertions

Nit: `out.stderr` is captured by `runUnderSeccomp()` but never surfaced in the flagged-run assertions, so if this test fails for a reason other than SIGSYS (e.g. an unrelated Bun panic, or a bug in the new `raw_syscall6` asm causing SIGSEGV) the CI diff will only show `stdout: ""` / `exitCode: 1` without the stderr explaining why. Consider adding `if (out.exitCode !== 0) expect(out.stderr).toBe("");` before line 202 (or folding `stderr: out.stderr` into the combined object) so failures are self-