bundler: chain external input sourcemaps and thread chains through the dev server - #32473
Open
robobun wants to merge 36 commits into
Open
bundler: chain external input sourcemaps and thread chains through the dev server#32473robobun wants to merge 36 commits into
robobun wants to merge 36 commits into
Claude / Claude Code Review
completed
Jun 17, 2026 in 20m 25s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/bundler/LinkerContext.rs:1095-1104 |
Stale comments: dev-server stitcher no longer hard-codes one sources[] slot |
Annotations
Check warning on line 1104 in src/bundler/LinkerContext.rs
claude / Claude Code Review
Stale comments: dev-server stitcher no longer hard-codes one sources[] slot
This comment (and its siblings in `js_printer/lib.rs` and `LinkerContext.zig:1430`) says `SourceMapStore::join_vlq` "hard-codes one `sources[]` slot per input", but this PR teaches `join_vlq` to track per-file `source_slot_count()` via `next_source_index` and `PackedMap.inner_sources` — so the rationale is now false. It directly contradicts the comment this same PR adds at `print_code_for_file_in_chunk_js` ("`SourceMapStore::join_vlq` now tracks per-file inner-source expansion"). The gate here i
Loading