postgres: fix do_run error-path leaks (poll_ref hang + query/statement refs) - #32464
Merged
Claude / Claude Code Review
completed
Jun 17, 2026 in 13m 15s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/sql/sql-postgres-run-error-pollref.test.ts:29-30 |
Test discards stderr, hiding diagnostics on failure |
Annotations
Check warning on line 30 in test/js/sql/sql-postgres-run-error-pollref.test.ts
claude / Claude Code Review
Test discards stderr, hiding diagnostics on failure
nit: `stderr` is read but discarded with `void stderr;`, so when the fixture fails for an incidental reason (container not ready, connection refused, fixture crash) the failure output will only show the `stdout` mismatch with no diagnostic context. Per root CLAUDE.md ("assert a combined `{ stdout, stderr, exitCode }` object"), fold stderr into the asserted object so it surfaces in the CI failure diff — just don't require it to be exactly empty (ASAN/debug builds emit benign noise).
Loading