Remove dead code across foundation crates - #32000
Closed
alii wants to merge 7 commits into
Closed
Claude / Claude Code Review
completed
Jun 24, 2026 in 16m 50s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/bun_core/string/mod.rs:2684-2694 |
New code comments exceed 3-line limit (CLAUDE.md rule 13) |
Annotations
Check warning on line 2694 in src/bun_core/string/mod.rs
claude / Claude Code Review
New code comments exceed 3-line limit (CLAUDE.md rule 13)
Nit: three new `//` comment blocks added in this diff exceed the 3-line cap from CLAUDE.md rule 13 — most notably the 11-line block here in `quote_for_json` (also `string/mod.rs:2441-2444`, 4 lines, and `clap_macros/lib.rs:270-274`, 5 lines). The heuristic rationale is useful; consider trimming each to ≤3 lines or promoting the longer ones to `///` doc comments on the function.
Loading