install: refresh URL/local tarballs under --force and explicit re-add/update - #31868
Open
robobun wants to merge 1 commit into
Open
install: refresh URL/local tarballs under --force and explicit re-add/update#31868robobun wants to merge 1 commit into
robobun wants to merge 1 commit into
Claude / Claude Code Review
completed
Jul 6, 2026 in 39m 49s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/install/PackageInstaller.rs:1510-1518 |
tarball_task_enqueued_this_run guard is redundant and causes partial refresh for multi-entry URL tarballs |
Annotations
Check warning on line 1518 in src/install/PackageInstaller.rs
claude / Claude Code Review
tarball_task_enqueued_this_run guard is redundant and causes partial refresh for multi-entry URL tarballs
The `!tarball_task_enqueued_this_run(url)` clause here (and its mirror in `isolated_install.rs:2373`) is redundant for its stated purpose — every "resolve phase already fetched it" case it guards against already has `PreinstallState::Done`, which `package_missing_from_cache` checks first. The only case where it fires distinctly is when an install-phase download for a *prior* entry of the same `package_id` is still in flight, and there it makes the second entry fall through to the stale on-disk c
Loading