test: make the ported Node suite run leak-clean under the ASAN runner, and fix the teardown UAFs and leaks it surfaces - #31833
Closed
cirospaciari wants to merge 23 commits into
Closed
test: make the ported Node suite run leak-clean under the ASAN runner, and fix the teardown UAFs and leaks it surfaces#31833cirospaciari wants to merge 23 commits into
cirospaciari wants to merge 23 commits into
Claude / Claude Code Review
completed
Jul 9, 2026 in 16m 36s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | .claude/skills/verify/SKILL.md:7-13 |
verify SKILL.md contradicts root CLAUDE.md on invoking bun-debug directly |
Annotations
Check warning on line 13 in .claude/skills/verify/SKILL.md
claude / Claude Code Review
verify SKILL.md contradicts root CLAUDE.md on invoking bun-debug directly
The new skill's headline instruction — "**Build once, then drive `./build/debug/bun-debug` directly**" (repeated at lines 13 and 20) — contradicts root `CLAUDE.md:18`, which says "you never invoke `./build/debug/bun-debug` directly." Both are agent-facing instruction docs loaded into context, so an agent following one violates the other. Either soften CLAUDE.md's "never" to allow post-build direct invocation for rapid probing, or have the skill use `bun bd -e '<snippet>'` (which per CLAUDE.md su
Loading