-
Notifications
You must be signed in to change notification settings - Fork 4.9k
domain: implement node:domain on AsyncLocalStorage and port the upstream domain suite #31828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cirospaciari
wants to merge
64
commits into
main
Choose a base branch
from
claude/port-node-domain-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
dfcd06d
domain: implement node:domain on AsyncLocalStorage and port the upstr…
cirospaciari c422740
domain: fix --abort-on-uncaught-exception on Windows and in Workers
cirospaciari dc480be
domain: skip remaining main-module-throw domain tests on Windows
cirospaciari 2edbcb0
domain: fix EventEmitter captureRejections bypass and async pairing leak
cirospaciari 4a1c169
runtime: don't arm the forever timer for a handled entry-point error
cirospaciari baa8e1d
test: review cleanups for the domain integration tests
cirospaciari 17fb9a9
process: only abort unhandled rejections after listeners decline
cirospaciari 9d66c3e
test: disable core dumps for the intentionally-aborting rejection child
cirospaciari 9658a11
domain: cover pre-load captureRejections emitters and write-first set…
cirospaciari dc33ddb
Merge branch 'main' into claude/port-node-domain-tests
robobun 58713fa
domain: address review feedback
alii 52d415c
process: abort unhandled rejections before listeners under --abort-on…
alii 32966e9
Merge branch 'main' into claude/port-node-domain-tests
alii a11bc05
domain: address review comments — re-read capture callback after moni…
alii 00e3c82
[autofix.ci] apply automated fixes
autofix-ci[bot] 58aa451
domain: sync stale abort-ordering doc comments and use stderr self-ma…
alii 2c83ab0
domain: decide --abort-on-uncaught-exception at throw time and route …
alii 2f28b5a
[autofix.ci] apply automated fixes
autofix-ci[bot] 1dc9f3c
Merge remote-tracking branch 'origin/main' into HEAD
alii 111dd2a
domain: report handled once _errorHandler is invoked; log after Worke…
alii 7f350cd
Merge branch 'main' into claude/port-node-domain-tests
cirospaciari 7707c06
Merge origin/main into claude/port-node-domain-tests
cirospaciari 5746e70
vm: pass substitute out-param via raw pointer to satisfy clippy::borr…
cirospaciari 77c2456
Merge origin/main into claude/port-node-domain-tests
cirospaciari 2dd9144
domain: consume a throw-time domain snapshot in the fallback abort gate
cirospaciari 402c892
domain: enter the paired domain for callbacks scheduled by the proces…
cirospaciari 0e6925a
test(domain): skip the abort-expecting node differential on Windows
cirospaciari 76623b3
Merge remote-tracking branch 'origin/main' into claude/port-node-doma…
robobun 56873fb
Merge branch 'main' into claude/port-node-domain-tests
robobun 3b9cbb1
domain: keep non-Domain process.domain values off the adopted stack
robobun 1a6b004
[autofix.ci] apply automated fixes
autofix-ci[bot] ac91edb
test: opt two worker-termination node tests out of dumpSimulatedThrows
robobun ef26dcd
Revert "test: opt two worker-termination node tests out of dumpSimula…
robobun 944aa88
Merge origin/main into claude/port-node-domain-tests
robobun 9ebd432
events: route EventEmitterAsyncResource.emit through the single proto…
robobun 2eba49c
Merge origin/main into claude/port-node-domain-tests
robobun 3512890
test: quarantine test-gc-http-client-connaborted.js on linux-x64-musl
robobun 5267fc2
cli: hide --abort_on_uncaught_exception from --help; drop the connabo…
robobun 596d276
Merge branch 'main' into claude/port-node-domain-tests
cirospaciari d4fb355
Merge branch 'main' into claude/port-node-domain-tests [allow size]
robobun 50610ee
Merge branch 'main' into claude/port-node-domain-tests
cirospaciari 03a2714
Merge branch 'main' into claude/port-node-domain-tests [allow size]
robobun a479a59
[autofix.ci] apply automated fixes
autofix-ci[bot] 5d72c65
domain: filter non-Domain process.domain values out of the wrapped Ev…
robobun e741b75
domain: make exports._stack and exports.active configurable like proc…
robobun 5e56ff2
Merge origin/main into claude/port-node-domain-tests
robobun 16e1f75
async_hooks: use a null-prototype descriptor for the AsyncResource .d…
robobun dfe9e79
domain,events,async_hooks,BunProcess: trim every PR-added comment to …
robobun 1172a20
vm: move UncaughtExceptionOrigin above the FFI section so the JSGloba…
robobun 0f08781
Merge remote-tracking branch 'origin/main' into claude/port-node-doma…
robobun e5fb274
test: suppress crash reporting for intentional --abort-on-uncaught-ex…
robobun 82c7d9f
Merge remote-tracking branch 'origin/main' into claude/port-node-doma…
robobun f5deb89
cleanupAsyncHooksData: skip the drain when no ticks are pending
robobun bd35aa8
Merge remote-tracking branch 'origin/main' into claude/port-node-doma…
robobun 08718bc
ci: retrigger
robobun c641f3f
Merge branch 'main' into port-node-domain-tests
cirospaciari 5685211
test-domain-promise: cite the upstream source for the omitted block
cirospaciari 6fc8040
Address review: null-guard the fatal-path stack walk, restore upstrea…
robobun 413bb58
[autofix.ci] apply automated fixes
autofix-ci[bot] 9f5ea3f
process.allowedNodeEnvironmentFlags: include --abort-on-uncaught-exce…
robobun a0b52c9
process._fatalException: log a Worker handler's own throw instead of …
robobun 61ca03f
domain: retire the live token at every tick boundary, not just the pr…
robobun 93a7dd0
domain: point the token-retire comment at node's after() hook, drop a…
robobun a9a46e4
Trim comments to node-source/spec references
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.