fs: batch small WriteStream writes via _writev and fix retry position - #31764
Open
robobun wants to merge 9 commits into
Open
fs: batch small WriteStream writes via _writev and fix retry position#31764robobun wants to merge 9 commits into
_writev and fix retry position#31764robobun wants to merge 9 commits into
Claude / Claude Code Review
completed
Jul 26, 2026 in 16m 52s
Code review found 1 potential issue
Found 4 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/sys/lib.rs:4570-4579 |
Rebase artifact: IOV_MAX batching now duplicated between node_fs.rs (main) and bun_sys (this PR) |
Annotations
Check warning on line 4579 in src/sys/lib.rs
claude / Claude Code Review
Rebase artifact: IOV_MAX batching now duplicated between node_fs.rs (main) and bun_sys (this PR)
Rebase artifact: main already landed IOV_MAX handling one layer up — `src/runtime/node/node_fs.rs` (not in this diff) defines `IOV_MAX` from libc and loops `writev_inner`/`pwritev_inner` in IOV_MAX-sized batches while capping `readv_inner`/`preadv_inner` (lines 262-270, 6273-6371), so the new `bun_sys` batching always sees ≤1024 iovecs and fast-paths, and `POSIX_IOV_MAX = 1024` duplicates the libc-derived constant. Same artifact in the tests: `describe.concurrent("writev/readv with more than IOV
Loading