Skip to content

Bump WebKit to 6d586e293f - #31706

Closed
Jarred-Sumner wants to merge 1 commit into
mainfrom
claude/bump-webkit-6d586e2
Closed

Bump WebKit to 6d586e293f#31706
Jarred-Sumner wants to merge 1 commit into
mainfrom
claude/bump-webkit-6d586e2

Conversation

@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

Updates WEBKIT_VERSION to oven-sh/WebKit@6d586e2, which adds the bun-webkit-windows-amd64-asan prebuilt variant (oven-sh/WebKit#240).

@robobun

robobun commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator
Updated 6:17 AM PT - Jun 2nd, 2026

@Jarred-Sumner, your commit 3cb9102 has 8 failures in Build #59870 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 31706

That installs a local version of the PR into your bun-31706 executable, so you can run:

bun-31706 --bun

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4f8ad132-41dc-42e3-934e-005990832d49

📥 Commits

Reviewing files that changed from the base of the PR and between f58d146 and 3cb9102.

📒 Files selected for processing (1)
  • scripts/build/deps/webkit.ts

Walkthrough

This PR updates the WEBKIT_VERSION constant in the build configuration to a new WebKit commit hash, which changes the identity of prebuilt artifacts and the target local checkout version for the build system.

Changes

WebKit Version Update

Layer / File(s) Summary
WebKit version constant update
scripts/build/deps/webkit.ts
WEBKIT_VERSION exported constant is bumped to a new commit hash (6d586e...), changing which WebKit prebuilt artifacts the build system targets.

Possibly related PRs

  • oven-sh/bun#31649: Updates upgrade documentation to instruct how to bump and pin the WEBKIT_VERSION constant in scripts/build/deps/webkit.ts.
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is incomplete. While it explains what the PR does, it lacks a 'How did you verify your code works?' section required by the template. Add a 'How did you verify your code works?' section to the description explaining the testing or verification approach used.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the main change: bumping WebKit to a specific commit hash. It is concise, clear, and directly summarizes the primary modification.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward WebKit version bump.

Extended reasoning...

Overview

This PR changes a single line in scripts/build/deps/webkit.ts, bumping the WEBKIT_VERSION constant from 963f8758... to 6d586e293f.... Per the description, the new oven-sh/WebKit release adds a bun-webkit-windows-amd64-asan prebuilt variant. No other code paths are touched.

Security risks

None. This is a version string constant that determines which prebuilt tarball is downloaded from oven-sh/WebKit releases (a repo controlled by the same org). There's no injection surface, auth, or permissions logic involved.

Level of scrutiny

Low. This is a routine, mechanical dependency version bump following the established pattern in this file. The constant is a 40-hex commit SHA, well-formed, and the surrounding logic (prebuiltSuffix, prebuiltUrl) already handles the -asan suffix on Windows, so no consumer changes are needed to take advantage of the new variant. CI will validate that the referenced release artifacts exist.

Other factors

No bugs were found by the bug hunting system, there are no outstanding reviewer comments, and the diff is a single-line constant change with clear intent.

@robobun

robobun commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Closing as superseded. #31724 landed this exact pin (6d586e293f008f0e74e5697611a379b1b24815c9) on 2026-06-02, and main has since moved on several more times; the current pin is 7b763944 (#37525), which contains 6d586e29.

@robobun robobun closed this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants