-
Notifications
You must be signed in to change notification settings - Fork 5k
Take the native blob path for Response-wrapped Bun.file() streams #31674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alii
wants to merge
22
commits into
main
Choose a base branch
from
ali/response-file-stream-sendfile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b5828d0
Take the native blob path for Response-wrapped Bun.file() streams
alii ac2acbf
[autofix.ci] apply automated fixes
autofix-ci[bot] 2e7d46c
test: add cancel/abort coverage for Response-wrapped file streams, us…
robobun 5bc5995
Detach consumed file streams and fix HTMLRewriter panic on file-backe…
robobun b89b420
Document why formData() keeps the streaming path, pin its file-stream…
robobun 95fae83
Drop dead to_blob_if_possible calls before try_blob_from_resolved_stream
robobun 9844fd7
Report Content-Length for HEAD on file-stream responses
robobun 65a3c01
Don't let resolve_size widen a sliced file Blob past its window
robobun 97cb5d7
ci: retrigger
robobun 8a7ef53
Merge branch 'main' into ali/response-file-stream-sendfile
alii aad89d3
Merge branch 'main' into ali/response-file-stream-sendfile
alii b6b4ae9
Merge branch 'main' into ali/response-file-stream-sendfile
alii 03f5418
Refuse native blob conversion of reader-locked body streams
robobun ee0309c
Mark every natively converted stream disturbed, not just file streams
alii 92e183c
Update blob-consumed stream test for the detached end state
robobun ab378e1
Document why the fetch-body buffering wait has no awaitable condition
robobun e1bb6f5
Clarify that has_reader implements only the reader half of the locked…
robobun 8da2c60
Wire the stream-to-blob conversion into formData and spawn stdio
robobun 36f4f70
Merge remote-tracking branch 'origin/main' into ali/response-file-str…
robobun 6f07d3b
Drop has_reader now that isLocked matches the locked builtin
robobun 675d347
Reclaim the Temporary read buffer in to_form_data_with_bytes
robobun 26fdee3
Merge remote-tracking branch 'origin/main' into ali/response-file-str…
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.