Hardening: input validation and bounds checking across 12 subsystems (round 8) - #31559
Merged
Claude / Claude Code Review
completed
May 29, 2026 in 19m 41s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/js/node/_http_client.ts:531-538 |
Synthetic ENOTFOUND error missing hostname property |
Annotations
Check warning on line 538 in src/js/node/_http_client.ts
claude / Claude Code Review
Synthetic ENOTFOUND error missing hostname property
Minor Node-compat nit: the synthetic ENOTFOUND error sets `name`/`code`/`syscall` but omits `error.hostname = host`, which Node's `dnsException()` includes and which user code commonly reads on ENOTFOUND for logging/retry. Adding it is a one-line addition; the pre-existing `fail()` helper a few lines below has the same gap, so this is consistent with the file but worth closing while you're here.
Loading