Skip to content

feat(ffi): enable bun:ffi on FreeBSD #31528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mfwolffe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(ffi): enable bun:ffi on FreeBSD #31528

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
281ea42
feat(ffi): enable bun:ffi on FreeBSD
mfwolffe May 28, 2026
22b7074
fix(ffi): remove FreeBSD from tcc_delete stub in mod.rs
mfwolffe May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion scripts/build/buildOptionsRs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ export function generateBuildOptionsRs(cfg: Config): string {
"pub const ENABLE_TINYCC: bool = !cfg!(any(",
` all(windows, target_arch = "aarch64"),`,
` target_os = "android",`,
` target_os = "freebsd",`,
"));",
"",
];
Expand Down
7 changes: 3 additions & 4 deletions scripts/build/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,10 +849,9 @@ export function resolveConfig(partial: PartialConfig, toolchain: Toolchain): Con
// failure is loud ("cannot find -l:libatomic.a") and the fix is obvious.
const staticLibatomic = partial.staticLibatomic ?? true;

// TinyCC: off on Windows ARM64 (not supported), Android (no upstream
// bionic support; FFI cc() falls back to dlopen-only), and FreeBSD
// (oven-sh/tinycc has no FreeBSD target).
const tinycc = partial.tinycc ?? !((windows && arm64) || abi === "android" || freebsd);
// TinyCC: off on Windows ARM64 (not supported) and Android (no upstream
// bionic support; FFI cc() falls back to dlopen-only).
const tinycc = partial.tinycc ?? !((windows && arm64) || abi === "android");

const valgrind = partial.valgrind ?? false;
const fuzzilli = partial.fuzzilli ?? false;
Expand Down
1 change: 1 addition & 0 deletions scripts/build/deps/tinycc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export const tinycc: Dependency = {
// driver) so we leave it at the default.
}
if (cfg.windows) defines.CONFIG_WIN32 = true;
if (cfg.freebsd) defines.TARGETOS_FreeBSD = true;

const spec: DirectBuild = {
kind: "direct",
Expand Down
13 changes: 10 additions & 3 deletions scripts/build/tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ function llvmSearchPaths(os: OS, arch: Arch): string[] {
paths.push("C:\\Program Files\\LLVM\\bin");
}

if (os === "linux" || os === "darwin") {
if (os === "linux" || os === "darwin" || os === "freebsd") {
paths.push("/usr/lib/llvm/bin");
// Debian/Ubuntu-style suffixed paths
paths.push(`/usr/lib/llvm-${LLVM_MAJOR}.${LLVM_MINOR}.0/bin`);
Expand All @@ -312,6 +312,12 @@ function llvmSearchPaths(os: OS, arch: Arch): string[] {
paths.push(`/usr/lib/llvm${LLVM_MAJOR}/bin`);
}

if (os === "freebsd") {
// FreeBSD ports install to /usr/local with unsuffixed version numbers
paths.push(`/usr/local/llvm${LLVM_MAJOR}/bin`);
paths.push("/usr/local/bin");
}

return paths;
}

Expand All @@ -325,6 +331,7 @@ function llvmNameVariants(name: string): string[] {
`${name}-${LLVM_MAJOR}.${LLVM_MINOR}.0`,
`${name}-${LLVM_MAJOR}.${LLVM_MINOR}`,
`${name}-${LLVM_MAJOR}`,
`${name}${LLVM_MAJOR}`, // FreeBSD ports: clang21, lld21
];
}

Expand Down Expand Up @@ -482,7 +489,7 @@ export function resolveLlvmToolchain(
let ld: string;
if (msvcTarget) {
ld = findLlvmTool("lld-link", paths, os, { checkVersion: false, required: true })?.path ?? "";
} else if (os === "linux") {
} else if (os === "linux" || os === "freebsd") {
ld = findLlvmTool("ld.lld", paths, os, { checkVersion: true, required: true })?.path ?? "";
} else {
ld = ""; // darwin: unused
Expand All @@ -502,7 +509,7 @@ export function resolveLlvmToolchain(
// Mach-O, so darwin cross-compiles need it (resolveConfig swaps it in).
let strip: string;
let llvmStrip: string | undefined;
if (os === "linux") {
if (os === "linux" || os === "freebsd") {
strip = findTool({ names: ["strip"], required: true, hint: "Install binutils for your distro" })?.path ?? "";
llvmStrip = findLlvmTool("llvm-strip", paths, os, { checkVersion: false, required: false })?.path;
} else {
Expand Down
8 changes: 4 additions & 4 deletions src/tcc_sys/tcc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ pub type TCCErrorFunc = Option<unsafe extern "C" fn(opaque: *mut c_void, msg: *c
pub type ErrorFunc<Ctx> = unsafe extern "C" fn(ctx: *mut Ctx, msg: *const c_char);

// `libtcc.a` is only built where `cfg.tinycc` is true (`scripts/build/config.ts`):
// not Windows/aarch64 (TinyCC has no aarch64-pe-coff backend), not Android, not
// FreeBSD (the vendored fork doesn't support those targets). On those platforms
// not Windows/aarch64 (TinyCC has no aarch64-pe-coff backend), not Android.
// On those platforms
// these `extern "C"` decls would be undefined at link. Zig's `comptime
// !Environment.enable_tinycc` early-returns in `ffi.zig` keep the *Zig*
// callers off the analysis graph, so the Zig externs never get emitted; Rust
Expand All @@ -31,13 +31,13 @@ pub type ErrorFunc<Ctx> = unsafe extern "C" fn(ctx: *mut Ctx, msg: *const c_char
// Keep this predicate in sync with `cfg.tinycc` in `scripts/build/config.ts`.
macro_rules! tcc_externs {
($($(#[$attr:meta])* fn $name:ident($($arg:ident: $ty:ty),* $(,)?) $(-> $ret:ty)?;)*) => {
#[cfg(not(any(target_os = "android", target_os = "freebsd", all(windows, target_arch = "aarch64"))))]
#[cfg(not(any(target_os = "android", all(windows, target_arch = "aarch64"))))]
// TODO(port): move to tcc_sys (already in *_sys crate — verify crate layout)
unsafe extern "C" {
$($(#[$attr])* fn $name($($arg: $ty),*) $(-> $ret)?;)*
}
$(
#[cfg(any(target_os = "android", target_os = "freebsd", all(windows, target_arch = "aarch64")))]
#[cfg(any(target_os = "android", all(windows, target_arch = "aarch64")))]
Comment thread
coderabbitai[bot] marked this conversation as resolved.
#[allow(unused_variables, clippy::missing_safety_doc)]
unsafe extern "C" fn $name($($arg: $ty),*) $(-> $ret)? {
unreachable!(concat!(
Expand Down