Hardening: input validation and protocol tightening across 24 subsystems (round 7) - #31495
Merged
Claude / Claude Code Review
completed
May 28, 2026 in 38m 24s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/runtime/cli/package_manager_command.rs:474-486 |
PR description parenthetical contradicts the resolved design for bun pm cache vs cache rm |
Annotations
Check warning on line 486 in src/runtime/cli/package_manager_command.rs
claude / Claude Code Review
PR description parenthetical contradicts the resolved design for bun pm cache vs cache rm
nit (description text only): the parenthetical "(`bun pm cache` prints the same path it would delete)" no longer matches the design settled in the resolved thread on this file — `bun pm cache` intentionally keeps the project-config-honoring `get_cache_directory(pm)` path while `bun pm cache rm` uses the process-env-only resolution, so the two can differ when a project-local `BUN_INSTALL_CACHE_DIR`/`.npmrc cache=` is set. Consider dropping or rewording the parenthetical (e.g. "`bun pm cache` cont
Loading