build: support cross-compiling Windows (x64 and arm64) from Linux - #31300
Merged
Claude / Claude Code Review
completed
May 26, 2026 in 19m 47s
Code review found 2 potential issues
Found 3 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/windows-app-info.rc:5-9 |
Native Windows manifest loses after switch from /MANIFEST:EMBED to .rc resource |
Annotations
Check warning on line 9 in src/windows-app-info.rc
claude / Claude Code Review
Native Windows manifest loses <requestedExecutionLevel> after switch from /MANIFEST:EMBED to .rc resource
nit: switching from `/MANIFEST:EMBED /MANIFESTINPUT:` to a raw `1 24` RT_MANIFEST resource changes the **shipping native** Windows manifest, not just the cross build — lld-link's manifest path used to merge a default `<trustInfo><requestedExecutionLevel level='asInvoker' uiAccess='false'/>` block into `src/bun.exe.manifest` (which only has `<windowsSettings>`), whereas the .rc route embeds the file verbatim, so that block is now absent. Practical impact is essentially nil (Installer Detection an
Loading