Skip to content

FileSystemRouter: keep the percent-decoded path buffer alive for the matched route #31208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FileSystemRouter: keep the percent-decoded path buffer alive for the matched route #31208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/js/bun/util/filesystem_router.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { FileSystemRouter } from "bun";
import { expect, it } from "bun:test";
import fs, { mkdirSync, rmSync } from "fs";
import { bunEnv, bunExe, isASAN, isMacOS, isWindows, tempDir, tmpdirSync } from "harness";
import { bunEnv, bunExe, isASAN, isDebug, isMacOS, isWindows, tempDir, tmpdirSync } from "harness";
import path, { dirname } from "path";

function createTree(basedir: string, paths: string[]) {
Expand Down Expand Up @@ -522,8 +522,9 @@ it("MatchedRoute.params does not leak", async () => {
const growthMB = (process.memoryUsage.rss() - before) / 1024 / 1024;
console.error("RSS growth: " + growthMB.toFixed(2) + "MB");
// ASAN's quarantine retains freed allocations (default 256 MB) so RSS
// deltas run far higher under bun-asan; widen the threshold there.
if (growthMB > ${isASAN ? 400 : 20}) throw new Error("leaked " + growthMB.toFixed(2) + "MB");
// deltas run far higher under ASAN. Debug builds enable ASAN by default,
// so treat them the same; the non-ASAN bound guards the actual leak.
if (growthMB > ${isASAN || isDebug ? 400 : 20}) throw new Error("leaked " + growthMB.toFixed(2) + "MB");
`;

await using proc = Bun.spawn({
Expand Down
Loading