Disable libpas JIT heap on Windows ARM64 - #31137
Open
sosukesuzuki wants to merge 1 commit into
Open
Claude / Claude Code Review
completed
May 20, 2026 in 15m 13s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | scripts/build/deps/webkit.ts:6 |
sync-webkit-source.ts breaks with tag-form WEBKIT_VERSION |
Annotations
Check warning on line 6 in scripts/build/deps/webkit.ts
claude / Claude Code Review
sync-webkit-source.ts breaks with tag-form WEBKIT_VERSION
Heads-up: pointing `WEBKIT_VERSION` at a tag name instead of a SHA breaks `scripts/sync-webkit-source.ts` for the local-WebKit workflow — `git rev-parse HEAD` can never equal the tag string so the early-exit at line 17 is dead, and `git pull` on `main` won't auto-follow a preview tag pointing at an unmerged PR commit, so `git checkout autobuild-preview-pr-234-c8f7dc7f` at line 24 will fail with `pathspec ... did not match` on existing clones. Prebuilt/CI is fine (the `autobuild-` prefix is alrea
Loading