blob: make StoreRef::data_mut unsafe, drop Sync - #30812
Open
robobun wants to merge 4 commits into
Open
Claude / Claude Code Review
completed
Aug 15, 2026 in 12m 20s
Code review found 4 potential issues
Found 1 candidates, confirmed 4. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 4 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/webcore_types.rs:1078-1080 |
data_mut doc groups resolve_file_stat under BlobExt:: prefix, but it is a free function |
Annotations
Check warning on line 1080 in src/jsc/webcore_types.rs
claude / Claude Code Review
data_mut doc groups resolve_file_stat under BlobExt:: prefix, but it is a free function
The `data_mut` `# Safety` doc's sibling enumeration reads "`BlobExt::shared_view_raw`/`set_is_ascii_flag`/`resolve_file_stat` in `webcore::blob`", but `resolve_file_stat` is a module-level free `unsafe fn resolve_file_stat(store: &StoreRef)` (Blob.rs:6203), not a `BlobExt` method — the slash-grouping mis-scopes it under the `BlobExt::` prefix. Suggest "`BlobExt::shared_view_raw`/`set_is_ascii_flag` and `resolve_file_stat` in `webcore::blob`". Comment accuracy only — no runtime impact.
Loading