Fix capacity miscount in ESMConditions.init - #30692
Closed
robobun wants to merge 3 commits into
Closed
Claude / Claude Code Review
completed
May 14, 2026 in 15m 28s
Code review found 1 important issue
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/bundler/options.zig:1575-1577 |
options.zig edit is a no-op: file is not compiled, and ESMConditions.init wasn't even changed |
Annotations
Check failure on line 1577 in src/bundler/options.zig
claude / Claude Code Review
options.zig edit is a no-op: file is not compiled, and ESMConditions.init wasn't even changed
This PR's only source change is to `src/bundler/options.zig`, but per `src/CLAUDE.md` the `.zig` files are non-compiled porting references — the shipped binary is built from `src/bundler/options.rs`, where `ESMConditions::init` already hoists `addon_extra` and uses growing `.insert()`, so the bug described in the PR body cannot occur there. On top of that, commit 28128c64 reverted the `ESMConditions.init` hunk from 1e2c22c7, so the net diff doesn't even touch that function — only the cosmetic pa
Loading