Root BuildMessage cells on the stack in Log.to_js - #30671
Closed
robobun wants to merge 8 commits into
Closed
Claude / Claude Code Review
completed
May 23, 2026 in 12m 41s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/resolve/build-error.test.ts:35-40 |
build-error.test.ts: BUN_JSC_collectContinuously not guarded on Windows |
Annotations
Check warning on line 40 in test/js/bun/resolve/build-error.test.ts
claude / Claude Code Review
build-error.test.ts: BUN_JSC_collectContinuously not guarded on Windows
Nit: this test sets `BUN_JSC_collectContinuously: "1"` unconditionally, but every other test in the repo that uses this env var — including this PR's own sibling test at `transpiler-async-error-uaf.test.ts:38-44` — gates it behind `!isWindows` with the rationale "Windows + collectContinuously is prohibitively slow in CI and the code path is platform-agnostic." The workload here is small so it may not actually time out, but for consistency consider spreading the env conditionally (e.g. `...(isWin
Loading