Fix crash in Bun.build when passing many custom conditions - #30660
Closed
robobun wants to merge 1 commit into
Closed
Fix crash in Bun.build when passing many custom conditions#30660robobun wants to merge 1 commit into
robobun wants to merge 1 commit into
Claude / Claude Code Review
completed
May 14, 2026 in 13m 3s
Code review found 1 potential issue
Found 4 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 1 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟣 Pre-existing | src/bundler/options.zig:1090-1092 |
Same if/else precedence footgun remains in loadersFromTransformOptions |
Annotations
Check notice on line 1092 in src/bundler/options.zig
claude / Claude Code Review
Same if/else precedence footgun remains in loadersFromTransformOptions
Pre-existing, non-blocking: the identical `if (cond) X else 0 + Y` precedence footgun also exists in `loadersFromTransformOptions` in this same file (lines 1574-1577). It's harmless there — the under-reserved capacity is followed by `getOrPutValue` calls that grow the map, so it only costs an extra rehash — but since this PR exists specifically to eliminate this pattern, you may want to apply the same `@intFromBool` fix there for consistency.
Loading