Fix stack overflow when inspecting circular JSX elements - #30657
Closed
robobun wants to merge 1 commit into
Closed
Claude / Claude Code Review
completed
May 14, 2026 in 15m 59s
Code review found 1 potential issue
Found 4 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 1 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟣 Pre-existing | src/test_runner/pretty_format.zig:328-330 |
pretty_format.zig: .Event missing from canHaveCircularReferences() |
Annotations
Check notice on line 330 in src/test_runner/pretty_format.zig
claude / Claude Code Review
pretty_format.zig: .Event missing from canHaveCircularReferences()
While you're on this line: `ConsoleObject.zig`'s `canHaveCircularReferences()` also includes `.Event`, but this version still doesn't. The `.Event` branch in `printAs()` here recurses via `this.format()` into a MessageEvent's `data` / ErrorEvent's `error`, so an event whose `data` points back to itself can still stack-overflow the Jest formatter — same root cause as the JSX fix. Pre-existing and contrived, but it's a one-token addition for parity.
Loading