Fix segfault in Bun.inspect for circular JSX elements - #30382
Closed
robobun wants to merge 1 commit into
Closed
Claude / Claude Code Review
completed
May 8, 2026 in 24m 4s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 1 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟣 Pre-existing | src/test_runner/pretty_format.zig:328-330 |
pretty_format.zig: .Event tag still missing from canHaveCircularReferences |
Annotations
Check notice on line 330 in src/test_runner/pretty_format.zig
claude / Claude Code Review
pretty_format.zig: .Event tag still missing from canHaveCircularReferences
Pre-existing nit: while you're touching this line, consider also adding `.Event` for parity with `ConsoleObject.zig:1139`. The `.Event` branch in this file's `printAs` recursively calls `this.format()` on the event's `data`/`error` sub-values, so a self-referential `MessageEvent`/`ErrorEvent` (e.g. via `Object.defineProperty(ev, 'data', {value: ev})`) would still recurse unboundedly in the Jest snapshot path. Not introduced by this PR — feel free to defer.
Loading