resolver: check union tag before reading cached .entries in dirInfoCachedMaybeLog - #30170
Merged
Merged
Claude / Claude Code Review
completed
May 3, 2026 in 8m 16s
Code review found 1 potential issue
Found 6 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/resolve/resolve.test.ts:573 |
Explicit test timeout violates test/CLAUDE.md convention |
Annotations
Check warning on line 573 in test/js/bun/resolve/resolve.test.ts
claude / Claude Code Review
Explicit test timeout violates test/CLAUDE.md convention
nit: per `test/CLAUDE.md` ("Do not set a timeout on tests. Bun already has timeouts."), the explicit `30_000` timeout argument should be dropped.
Loading