node:worker_threads: implement postMessageToThread [1bx5ty] - #29828
Closed
robobun wants to merge 51 commits into
Closed
node:worker_threads: implement postMessageToThread [1bx5ty]#29828robobun wants to merge 51 commits into
robobun wants to merge 51 commits into
Claude / Claude Code Review
completed
Apr 29, 2026 in 33m 29s
Code review found 1 potential issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/bun.js/bindings/webcore/JSWorker.cpp:320-327 |
Stale comment in WorkerOptions.h: serialized array now has 3 elements |
Annotations
Check warning on line 327 in src/bun.js/bindings/webcore/JSWorker.cpp
claude / Claude Code Review
Stale comment in WorkerOptions.h: serialized array now has 3 elements
nit: The field comment in `WorkerOptions.h:27-30` still says "Serialized array containing [workerData, environmentData]" / "Objects transferred for either data or environmentData in the transferList", but this PR extended the array to `[workerData, environmentData, mainThreadPort]` and appended `mainThreadPort` to the transfer list. The parallel comment in `Worker.cpp:596` was updated ("Array of length 3"), so this one was just missed — worth syncing while you're here.
Loading