inspect: handle throwing Proxy getPrototypeOf in forEachProperty - #29814
Closed
robobun wants to merge 3 commits into
Closed
inspect: handle throwing Proxy getPrototypeOf in forEachProperty#29814robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
May 4, 2026 in 28m 32s
Code review found 2 potential issues
Found 2 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 1 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟣 Pre-existing | src/jsc/bindings/bindings.cpp:5448-5453 |
Same getPrototype().getObject() null-deref remains in napi.cpp |
Annotations
Check notice on line 5453 in src/jsc/bindings/bindings.cpp
claude / Claude Code Review
Same getPrototype().getObject() null-deref remains in napi.cpp
Pre-existing / non-blocking: the identical unguarded `getPrototype(globalObject).getObject()` pattern this PR fixes also exists at `src/jsc/bindings/napi.cpp:1837` inside `napi_get_all_property_names` — a Proxy with a throwing `getPrototypeOf`/`getOwnPropertyDescriptor` trap in the prototype chain triggers the same null-member-call there. Sibling PR #29642 bundled that napi.cpp fix; flagging so it isn't lost if #29642 is closed in favor of this minimal PR.
Loading