console: guard JSX/Proxy recursion in Bun.inspect (stack overflow SIGSEGV) - #29709
Open
robobun wants to merge 3 commits into
Open
console: guard JSX/Proxy recursion in Bun.inspect (stack overflow SIGSEGV)#29709robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Aug 13, 2026 in 16m 53s
Code review found 3 potential issues
Found 2 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 1 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/util/inspect.test.js:348 |
Subprocess tests pipe both stdout/stderr but only drain one |
Annotations
Check warning on line 348 in test/js/bun/util/inspect.test.js
claude / Claude Code Review
Subprocess tests pipe both stdout/stderr but only drain one
Nit: the ad20a7a4 spawnSync→`Bun.spawn` conversion left all six new tests configuring both `stdout: "pipe"` and `stderr: "pipe"` but only draining one in the `Promise.all` (lines 348/370/450/483 skip stderr; 397/426 skip stdout). REVIEW.md's "Subprocess tests: drain pipes concurrently" rule and this file's own convention (the two pre-existing async-spawn tests both do `Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited])`) require draining both — an unread pipe that fills the ~64KB
Loading