console: guard JSX/Proxy recursion in Bun.inspect (stack overflow SIGSEGV) - #29709
Open
robobun wants to merge 3 commits into
Open
console: guard JSX/Proxy recursion in Bun.inspect (stack overflow SIGSEGV)#29709robobun wants to merge 3 commits into
robobun wants to merge 3 commits into
Claude / Claude Code Review
completed
Aug 13, 2026 in 17m 39s
Code review found 2 potential issues
Found 1 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 1 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/util/inspect.test.js:319-347 |
New subprocess tests use spawnSync serially instead of async spawn / test.concurrent |
Annotations
Check warning on line 347 in test/js/bun/util/inspect.test.js
claude / Claude Code Review
New subprocess tests use spawnSync serially instead of async spawn / test.concurrent
Nit: the six new subprocess tests use `Bun.spawnSync` and run serially, diverging from REVIEW.md's "async spawns over `spawnSync`" / "`test.concurrent` for independent subprocess suites" and from this file's own convention — the two pre-existing subprocess tests here ("huge sparse array", "object mutated while being formatted") both use `await using proc = Bun.spawn(...)` + `Promise.all([stdout.text(), stderr.text(), exited])`. Six independent full-`bun` spawns (two of which build 100k / 20k obj
Loading