-
Notifications
You must be signed in to change notification settings - Fork 5k
install: isolated linker honors active bun link #29615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Kniggishood
wants to merge
9
commits into
oven-sh:main
from
Kniggishood:claude/isolated-linker-honors-bun-link
Closed
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
092bf9b
install: isolated linker honors active bun link
Kniggishood ec74105
install: propagate producer rebuilds + tests + windows stat
Kniggishood 721837c
install: isolated+link filters producer tree through npm publish defa…
Kniggishood 63a8f8e
install: isolated+link honors producer's package.json#files whitelist
Kniggishood e30bc30
install: cache global link dir names for O(1) linkedPackagePath lookups
Kniggishood 56d1649
install: address PR #29615 review feedback
Kniggishood 7718c6a
isolated-link: route producer tree through pack file selector
Kniggishood 8a88cc7
test(isolated-install): wrap inline producer tempDirs with using
Kniggishood 6a90c13
address PR review: OOM propagation, non-array files fallback, test cl…
Kniggishood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid caching a half-initialized global link dir.
If
bun.getFdPath()fails here,populateLinkedNamesCache()returns withthis.global_link_diralready set butthis.global_link_dir_pathstill empty. A laterglobalLinkDirPath()call then skips re-initialization and can build linked-package paths from"". Move the field assignments until after the path lookup succeeds, and close the local dirs on the early-return path.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents