http: publish to http.server.* diagnostics_channel channels - #29588
Closed
robobun wants to merge 11 commits into
Closed
http: publish to http.server.* diagnostics_channel channels#29588robobun wants to merge 11 commits into
robobun wants to merge 11 commits into
Claude / Claude Code Review
completed
Jul 15, 2026 in 14m 20s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/js/node/http2.ts:5576-5582 |
http2 allowHTTP1: response.finish now publishes before res.finished flips true |
Annotations
Check warning on line 5582 in src/js/node/http2.ts
claude / Claude Code Review
http2 allowHTTP1: response.finish now publishes before res.finished flips true
Moving the allowHTTP1 `response.finish` publish into `handle.onfinished` fixed `socket.writableEnded` but traded it for the mirror-image divergence: `handle.onfinished` runs synchronously inside `handle.end()` — before `ServerResponse.prototype.end` sets `this.finished = true` and before `emit('finish')` — so on this path a subscriber now observes `payload.response.finished === false` / `writableFinished === false`, whereas the plain `http.createServer` path (and Node, where `resOnFinish` is a `
Loading