ci: fix tart.mjs unresolved refs, add snapshot(), use -base images - #29315
Open
alii wants to merge 14 commits into
Open
ci: fix tart.mjs unresolved refs, add snapshot(), use -base images#29315alii wants to merge 14 commits into
alii wants to merge 14 commits into
Claude / Claude Code Review
completed
Apr 17, 2026 in 21m 13s
Code review found 2 potential issues
Found 3 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | scripts/machine.mjs:1043 |
Snapshot typedef optional marker incorrect — tart always throws on undefined label |
Annotations
Check warning on line 1043 in scripts/machine.mjs
claude / Claude Code Review
Snapshot typedef optional marker incorrect — tart always throws on undefined label
The Machine typedef's `snapshot` property was updated to `(label?: string) => Promise<string>`, but the `?` optional marker is incorrect for tart's implementation. Tart immediately throws if `label` is falsy (`if (\!label) throw new Error("tart snapshot() requires a label")`), unlike AWS which gracefully falls back to a timestamped name. The correct signature is `(label: string) => Promise<string>` — no `?`.
Loading