ci: fix tart.mjs unresolved refs, add snapshot(), use -base images - #29315
Open
alii wants to merge 14 commits into
Open
ci: fix tart.mjs unresolved refs, add snapshot(), use -base images#29315alii wants to merge 14 commits into
alii wants to merge 14 commits into
Claude / Claude Code Review
completed
Apr 17, 2026 in 20m 39s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | scripts/tart.mjs:297-303 |
tart toMachine() return object missing imageId/instanceType/region |
Annotations
Check warning on line 303 in scripts/tart.mjs
claude / Claude Code Review
tart toMachine() return object missing imageId/instanceType/region
tart.toMachine() returns an object without imageId, instanceType, or region, so the 'Created machine:' console.table printed by machine.mjs after createMachine() will show 'undefined' for all three fields on every tart create-image run. The fix is to add imageId (the OCI image string from createMachine's image variable), instanceType (a cpu/mem summary string), and region: 'local' to the returned object.
Loading