Skip to content

Parse and lower accessor fields under experimentalDecorators - #29201

Closed
robobun wants to merge 3 commits into
mainfrom
farm/9ef3d383/accessor-experimental-decorators
Closed

Parse and lower accessor fields under experimentalDecorators#29201
robobun wants to merge 3 commits into
mainfrom
farm/9ef3d383/accessor-experimental-decorators

drop no-panic stderr assertions per CLAUDE.md

00b6d65
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 13, 2026 in 17m 30s

Code review found 1 important issue

Found 1 candidates, confirmed 3. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 2
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/regression/issue/29197.test.ts:1-10 Test file misplaced: #29197 is a missing feature, not a regression

Annotations

Check warning on line 10 in test/regression/issue/29197.test.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Test file misplaced: #29197 is a missing feature, not a regression

Per CLAUDE.md, `test/regression/issue/${N}.test.ts` is reserved for *true regressions* (worked in a previous release, then broke) — but the PR's own root-cause section says `accessor` under `experimentalDecorators: true` was always gated off, so #29197/#27335 are missing-feature bugs, not regressions. These transpiler/decorator tests belong in `test/bundler/transpiler/decorators.test.ts` (which is where replacement PR #38125 already puts them, per robobun's 2026-08-13 comment).