Skip to content

Fix link to CPU Requirements in README.md - #29108

Open
yury-atk wants to merge 1 commit into
oven-sh:mainfrom
yury-atk:patch-2
Open

Fix link to CPU Requirements in README.md#29108
yury-atk wants to merge 1 commit into
oven-sh:mainfrom
yury-atk:patch-2

Conversation

@yury-atk

Copy link
Copy Markdown

Fix link to CPU Requirements

What does this PR do?

Fix link to CPU Requirements in README.md file

How did you verify your code works?

Just click to link and see that now it redirect to valid section with CPU Requirements.

Fix link to CPU Requirements

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai

coderabbitai Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 779c8b43-f61c-4cdd-8b09-9afa253fd637

📥 Commits

Reviewing files that changed from the base of the PR and between 8e65e47 and 84fb9eb.

📒 Files selected for processing (1)
  • README.md

Walkthrough

README.md was updated to modify a documentation link reference. An anchor link in the x64 "illegal instruction" guidance section was changed from #cpu-requirements-and-baseline-builds to #cpu-requirements to point to a different CPU requirements documentation section.

Changes

Cohort / File(s) Summary
Documentation Updates
README.md
Updated URL anchor in x64 "illegal instruction" guidance from #cpu-requirements-and-baseline-builds to #cpu-requirements.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: fixing a link to CPU Requirements in README.md.
Description check ✅ Passed The description includes both required sections with appropriate details about what the PR does and how it was verified.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@robobun

robobun commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Confirming this is the fix to keep. The docs heading is ## CPU Requirements in docs/installation.mdx on main (the old cpu-requirements-and-baseline-builds anchor went away with the docs swap in #24201), and the published page only has id="cpu-requirements", so the new target is right. Closed #30131 and #31622 as duplicates of this one. Note for whoever merges: #36465 carries the same one-line README hunk as part of a larger docs update, so whichever lands first makes the other's README change a no-op.

@alii

alii commented Aug 12, 2026

Copy link
Copy Markdown
Member

@robobun should we simply merge #36465 then?

@robobun

robobun commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Yes, merging #36465 covers this. Its README hunk produces the same line 50 as this PR, so once it lands this one has nothing left to apply and can be closed.

I re-checked #36465 against today's main before answering. It still merges cleanly (the only upstream change to any file it touches is the control character fix in docs/installation.mdx from #37219, which auto-merges), and test/internal/release-asset-coherence.test.ts still passes on the merged tree. What it documents is also still how main behaves: upload-release.sh rezips the plain x64 zip under the -baseline name, the @oven/*-x64-baseline entries in packages/bun-release/src/platform.ts are still alias: true, and compile_target.rs still accepts the -baseline and -modern suffixes. CI was green on its last push and it has no open review threads.

If you would rather land this one first so the author gets credit for the link fix, that works too. I merged them in that order locally and #36465 still applies without conflicts, since the README change is identical in both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants