Fix TOML multi-line string trimming - #28682
Closed
robobun wants to merge 9 commits into
Closed
Claude / Claude Code Review
completed
Jun 6, 2026 in 19m 59s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/bun/resolve/toml/toml.test.js:116-118 |
Missing CRLF test coverage for new multi-line string code paths |
Annotations
Check warning on line 118 in test/js/bun/resolve/toml/toml.test.js
claude / Claude Code Review
Missing CRLF test coverage for new multi-line string code paths
nit: The new `trim_multiline_start` has a dedicated `\r\n` branch (returning `content_start + 2`), and the `\\<CR>` line-continuation arm has a CRLF lookahead (`if text[pos] == b'\n' { pos += 1 }`), but all six new tests use LF-only template literals so neither branch executes. Per CLAUDE.md's "cover the variant matrix, not just the repro", and given a CRLF bug was found in this PR's own review cycle, a quick `Bun.TOML.parse('str = """\r\nhello"""')` → `'hello'` and `'str = """a\\\r\n b"""'` →
Loading