fix: url.format() should support options parameter

[ssing2]

Fixes #24233

Node.js url.format() accepts an options object to control URL formatting, but Bun's implementation ignored this parameter.

Problem

import url from 'node:url';
const myURL = new URL('https://example.org?abc#foo');

console.log(url.format(myURL, { fragment: false }));
// Expected: 'https://example.org/?abc'
// Actual (Bun before fix): 'https://example.org/?abc#foo'

Solution

Modified Url.prototype.format() to accept and respect the options parameter:

• fragment: false - removes the fragment (#foo)
• Other options documented for future expansion

Changes

• Modified src/js/node/url.ts
• Added options parameter with TypeScript type
• Implemented fragment option to control hash inclusion
• Matches Node.js url.format() behavior

Test Case

import url from 'node:url';

const myURL = new URL('https://example.org?abc#foo');

// fragment: false removes the hash
console.log(url.format(myURL, { fragment: false }));
// Output: 'https://example.org/?abc' ✓

// Default behavior includes fragment
console.log(url.format(myURL));
// Output: 'https://example.org/?abc#foo' ✓

[coderabbitai]

Warning

Rate limit exceeded

@ssing2 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 38 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8e0b2838-33fa-405a-8ad7-1b755b337f66

📥 Commits

Reviewing files that changed from the base of the PR and between e2b0d24 and 8493a62.

📒 Files selected for processing (1)

• src/js/node/url.ts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[robobun]

Thanks for the PR. This behavior landed on main separately in #34660, which makes url.format honor the options object for WHATWG URL input, so #24233 is now closed.

Verified on a build of current main (165dc9f): url.format(new URL("https://example.org?abc#foo"), { fragment: false }) returns https://example.org/?abc, matching node v26.3.0.

This PR is no longer needed, so closing it.