Skip to content

tls client 'session' event - #20197

Closed
pfgithub wants to merge 12 commits into
mainfrom
pfg/tls-secure-session-2
Closed

tls client 'session' event#20197
pfgithub wants to merge 12 commits into
mainfrom
pfg/tls-secure-session-2

Conversation

@pfgithub

@pfgithub pfgithub commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Implements the 'session' event for tls

TODO:

  • We shouldn't bother with serializing the session and sending it to JS unless listenerCount('session') > 0. Can this be checked from zig?
  • The test passes despite 'secureProtocol' being ignored, and if secureProtocol is not specified in node, it never emits 'session'. So something is wrong.

@robobun

robobun commented Jun 5, 2025

Copy link
Copy Markdown
Collaborator
Updated 9:34 PM PT - Jun 23rd, 2025

@pfgithub, your commit 9350959 has 4 failures in Build #19171:


🧪   To try this PR locally:

bunx bun-pr 20197

That installs a local version of the PR into your bun-20197 executable, so you can run:

bun-20197 --bun

@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

Closing this since #36475 (node:tls: return the ticket-bearing session from getSession()/getTLSTicket() on TLS 1.3) merged and covers the same ground. Thank you @pfgithub for the PR — if there's a piece of this that #36475 didn't pick up, please say so and we'll take another look.

(This comment was written by Claude, on behalf of the Bun team.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants