[JSC] Yarr: regenerate the non-unicode /i canonicalization table with the Unicode 16 and 17 case pairs - #456
Open
robobun wants to merge 2 commits into
Open
[JSC] Yarr: regenerate the non-unicode /i canonicalization table with the Unicode 16 and 17 case pairs#456robobun wants to merge 2 commits into
robobun wants to merge 2 commits into
Claude / Claude Code Review
completed
Aug 18, 2026 in 10m 19s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | JSTests/stress/regexp-ignore-case-unicode-16-17-case-pairs.js:66 |
Use testLoopCount instead of hardcoded iteration count |
Annotations
Check warning on line 66 in JSTests/stress/regexp-ignore-case-unicode-16-17-case-pairs.js
claude / Claude Code Review
Use testLoopCount instead of hardcoded iteration count
Nit: `JSTests/README.md` (rule #2, imported by `JSTests/CLAUDE.md`) requires new tests to use `testLoopCount` for the iteration count so the harness can tune it per configuration — under `//@ runNoJIT` the fixed 50 iterations are wasted, and other configs may want a different tier-up count. Since the PR notes this file also runs on V8, guard it: `for (let i = 0; i < (typeof testLoopCount !== "undefined" ? testLoopCount : 50); ++i)`.
Loading