Skip to content

testFFI: compare NaN returns semantically in the invoke-thunk differential #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 2 commits into from
Jul 28, 2026
Merged

testFFI: compare NaN returns semantically in the invoke-thunk differential #367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0f6135
testFFI: compare NaN returns semantically in the invoke-thunk differe…
Jarred-Sumner Jul 28, 2026
f8f2eb7
testFFI: gate the NaN-equal fallback on multi-argument fixtures
Jarred-Sumner Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Source/JavaScriptCore/ffi/tests/testFFI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1527,7 +1527,15 @@ static void differentialCase(ASCIILiteral name, R (*function)(Arguments...), Vec
R nativeResult = callNativeFromSlots(function, nativeSlots.span().data());
uint64_t expected = canonicalizeSlot(returnType, nativeReturnRawBits(nativeResult));
uint64_t actual = slots[argumentCount];
ok &= actual == expected;
bool returnsEqual = actual == expected;
constexpr bool operandOrderCanFlipNaNPayload = sizeof...(Arguments) >= 2;
if constexpr (operandOrderCanFlipNaNPayload) {
if (!returnsEqual && returnType == FFI::Type::Double)
returnsEqual = std::isnan(std::bit_cast<double>(actual)) && std::isnan(std::bit_cast<double>(expected));
else if (!returnsEqual && returnType == FFI::Type::Float)
returnsEqual = std::isnan(std::bit_cast<float>(static_cast<uint32_t>(actual))) && std::isnan(std::bit_cast<float>(static_cast<uint32_t>(expected)));
}
ok &= returnsEqual;
Comment thread
Jarred-Sumner marked this conversation as resolved.
if (!ok) {
s_failureCount++;
dataLogLn(" FAIL: invoke-thunk differential for ", name.characters(), " (", signature->toString(), ") iteration ", iteration,
Expand Down
Loading