Skip to content

ModuleLoader: record a non-Error fetch rejection as a fetch failure #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 1 commit into from
Jun 30, 2026
Merged

ModuleLoader: record a non-Error fetch rejection as a fetch failure #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Source/JavaScriptCore/runtime/JSMicrotask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,6 +1124,11 @@ static void moduleLoadTopSettled(JSGlobalObject* globalObject, VM& vm, ThrowScop
entry->setEvaluationError(globalObject, error);
else
entry->setFetchError(globalObject, error);
} else {
// This microtask reacts to the embedder fetch promise, so a rejection
// here is a fetch failure even when the host rejected with a non-Error
// value (matching moduleRegistryFetchSettled's unconditional setFetchError).
entry->setFetchError(globalObject, errorValue);
}
intermediatePromise->reject(vm, errorValue);
}
Expand Down
Loading